This repository was archived by the owner on Feb 9, 2024. It is now read-only.
Glasgow - Class 6 --- Rahma - Appolin - Nasir --- React - Hotel Group Project #596
Open
ali-nasir-ali wants to merge 64 commits intoCodeYourFuture:masterfrom
Open
Glasgow - Class 6 --- Rahma - Appolin - Nasir --- React - Hotel Group Project #596ali-nasir-ali wants to merge 64 commits intoCodeYourFuture:masterfrom
ali-nasir-ali wants to merge 64 commits intoCodeYourFuture:masterfrom
Conversation
1 header component
worked on search
3 tourist info cards
…ings---component 5-hard coded table
…ooking_to_SearchRresults 6 -- using props to pass fake booking to search results
…onent 8-render-restaurant-component
7- Calculate and show the number of nights
…-orders-to-Restaurant Added orders state variable to Restaurant component
13 render more orders
…hen-clicked 15 -- highlight booking row when clicked
…-in-a-state 17 - Storing the search input in a state
…Submitting-the-form 18 -- Added onSubmit event handler on the form
added api capabilities
…nctionality 19 implementing search functionality
…r-profile---step-1 20 --- display a customer profile step 1
…ile-step-2 21 -- Added some functionality to show profile button and customerProfile com…
23 -- Added the error message when url not working
22 loading message
|
Kudos, SonarCloud Quality Gate passed!
|
hanl00
reviewed
Jul 7, 2023
Comment on lines
+26
to
+34
| <th scope="row">{props.booking.id}</th> | ||
| <td>{props.booking.title}</td> | ||
| <td>{props.booking.firstName}</td> | ||
| <td>{props.booking.surname}</td> | ||
| <td>{props.booking.email}</td> | ||
| <td>{props.booking.roomId}</td> | ||
| <td>{props.booking.checkInDate}</td> | ||
| <td>{props.booking.checkOutDate}</td> | ||
| <td>{props.numberOfNights}</td> |
There was a problem hiding this comment.
destructuring the object here would be nice, you dont have to type props.booking. on every line
annacollins85
left a comment
annacollins85
left a comment
There was a problem hiding this comment.
Reviewed together in buddy session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.